Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jenkins test harness from hpi file, require Jenkins 2.361.4 or newer #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MarkEWaite
Copy link

Require Jenkins 2.361.4 or newer and Java 11

Also removes Jenkins test harness from the plugin packaging

DOES NOT FIX THE INCORRECT MODIFICATION OF ARTIFACT ID

#1 needs partial revert to restore original artifact ID and package ID.

Remove Jenkins test harness HTMLUnit from the plugin hpi file

jenkinsci/jenkins#8714 included in Jenkins 2.434 and later will refuse to load a plugin that includes the Jenkins test harness.

The Jenkins test harness causes unexpected failures when it is included in a Jenkins plugin. Refer to the following issue reports for examples:

The additional benefit of the change is that it makes the plugin hpi file over 90% smaller.

Testing done

Confirmed automated tests pass.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

Also removes Jenkins test harness from the plugin packaging

DOES NOT FIX THE INCORRECT MODIFICATION OF ARTIFACT ID
jenkinsci#1 needs partial
revert to restore original artifact ID and package ID.

Remove Jenkins test harness HTMLUnit from the plugin hpi file

jenkinsci/jenkins#8714 included in Jenkins
2.434 and later will refuse to load a plugin that includes the Jenkins
test harness.

The Jenkins test harness causes unexpected failures when it is included
in a Jenkins plugin.  Refer to the following issue reports for examples:

* https://issues.jenkins.io/browse/JENKINS-65650
* https://issues.jenkins.io/browse/JENKINS-66060
* https://issues.jenkins.io/browse/JENKINS-72353

The additional benefit of the change is that it makes the plugin hpi
file over 80% smaller.
@MarkEWaite
Copy link
Author

Jenkins 2.434 and later will refuse to load this plugin until a new release is generated that includes this change. However, as noted in the pull request description, there is a breaking change that was made in

That breaking change altered the artifact ID. Changing artifact ID is generally not supported or recommended by the Jenkins project. Before the next release, the artifact ID and project ID will need to be the same as the original release.

@MarkEWaite MarkEWaite changed the title Require Jenkins 2.361.4 or newer and Java 11 Require Jenkins 2.361.4 or newer, remove Jenkins test harness Dec 18, 2023
@MarkEWaite MarkEWaite changed the title Require Jenkins 2.361.4 or newer, remove Jenkins test harness Remove Jenkins test harness from hpi file, require Jenkins 2.361.4 or newer Dec 18, 2023
@MarkEWaite
Copy link
Author

MarkEWaite commented Jan 5, 2024

@iTMSJenkins, @tuhuynhInfodation, and @tuhuynh2013 this plugin will not load in Jenkins 2.434 and newer. A new release of the plugin needs to be created. That new release needs to include the changes in this pull request.

If users need a version of the plugin that runs with Jenkins 2.434 or newer, they can install a pre-release from https://ci.jenkins.io/job/Plugins/job/itms-for-jira-plugin/job/PR-5/lastSuccessfulBuild/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant