Fix permission type in checkAgentUserPermission function

jenkinsci · Jul 18, 2023 · 708d7aa · 708d7aa
1 parent 90b89ac
commit 708d7aa
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java b/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java
@@ -250,11 +250,10 @@ private boolean checkReadPermission(@NonNull Permission permission) {
     }
 
     private boolean checkAgentUserPermission(@NonNull Permission permission) {
-        String id = permission.getId();
-        return (id.equals(Hudson.READ)
-                || id.equals(Computer.CREATE)
-                || id.equals(Computer.CONNECT)
-                || id.equals(Computer.CONFIGURE));
+        return permission.equals(Hudson.READ)
+                || permission.equals(Computer.CREATE)
+                || permission.equals(Computer.CONNECT)
+                || permission.equals(Computer.CONFIGURE);
     }
 
     private boolean checkJobStatusPermission(@NonNull Permission permission) {