[JENKINS-62767] Need to bundle org.eclipse.jgit.ssh.jsch #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was hoping that a passing build would publish incrementals for people to try, but @MarkEWaite #559 broke incremental artifact publishing as per logic in jenkins-infra/pipeline-library#46. Keep it simple… |
MarkEWaite
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
Thanks very much!
Confirmed that it works in the git provider tests that I run with:
- Assembla
- Beanstalk
- Bitbucket
- GitHub
- GitLab
- Microsoft Visual Studio Team Services
Also confirmed that the automated tests pass with Java 8 and with Java 11 and on multiple platforms. Will run some additional checks and then will release a new version of git client plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-62767 - need to bundle org.eclipse.jgit.ssh.jsch
Amends #561 to handle https://github.com/eclipse/jgit/commit/8d2d683655e2de17cf465fa46af10e0e56b3aaed.
Not tested in any way, except verifying that the list of bundle JARs now looks saner and includes the missing class.