Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.204.1 or later #532

Merged
merged 7 commits into from
Apr 2, 2020

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Mar 31, 2020

Require Jenkins 2.204.1 or later

This pull request switches from requiring Jenkins 2.138.4 as minimum version to require Jenkins 2.204.1 as minimum version. Using a modern version like 2.204.1 includes the trilead-api separation from the Jenkins core and simplifies testing.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)

Further comments

User based justification for choosing 2.204.1 as the new minimum version:

  • Over 50% of the 240 000 installations of git client plugin are running git client plugin 3.0.0 or newer. Over 40 000 git client plugin installations are using Jenkins 2.204.2
  • Almost 10x more installations of git client plugin are on Jenkins 2.204.2 than any other single release

Users that are choosing to stay current with the git client plugin are also choosing to stay current with Jenkins releases. That's a very good thing. Special thanks to the users for choosing to update to recent releases!

The Jenkinsfile is now configured to test Jenkins 2.204.6 on Windows with Java 8 and Jenkins 2.222.1 or 2.204.6 on Linux with both Java 8 and Java 11. It intentionally tests the most recent release of Jenkins 2.204.x while only requiring 2.204.1 so that users of 2.204.2 are not forced to update to use the git client plugin.

There are still some spotbugs warnings that will either need to be suppressed, resolved, or hidden by restoring the spotbugs settings that were used until the recent update to spotbugs 4.0.1. Specifically, the spotbugs threshold was previously set to 'High' with the effort set to 'Low'. The new settings invert that and set the threshold to 'Low' and the effort to 'Max'.

This change intentionally uses plugin pom 4.0-beta with the assumption that plugin pom 4.0 will be released within the next month or so. If it is not released in that time, then the most recent released parent will be used instead.

Marching pull request for git plugin at jenkinsci/git-plugin#862

Copy link
Contributor

@fcojfernandez fcojfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. I've left a question just to get a better insight about how the plugin is built. thanks in avance!

Jenkinsfile Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency related change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants