Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JENKINS-33258 tests into CLI specific tests #525

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Mar 20, 2020

Move JENKINS-33258 tests into CLI specific tests

The assertions are checking log messages that are only available from CLI git. No reason to spend time or energy calling methods that won't generate the necessary logging output.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)

@rishabhBudhouliya this was an assertion that was missed in the transition from JUnit 3 to JUnit 4. The assertion after the test completes was too subtle. I like the JUnit 4 style that is expressed in this test now. It makes explicit checks within the individual test, instead of performing checks at the end of every test.

@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Mar 20, 2020
The assertions are checking log messages that are only available from
CLI git.  No reason to spend time or energy calling methods that
won't generate the necessary logging output.
@MarkEWaite MarkEWaite merged commit 4be0932 into jenkinsci:master Mar 20, 2020
@MarkEWaite MarkEWaite deleted the restore-rev-parse-tests branch March 20, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant