Some GitAPITestCase tests were replaced in GitClientTest

[loghijiaha]

JENKINS-60940 - Tests were added to GItClientTest

Checklist

• I have read the CONTRIBUTING doc
• I have referenced the Jira issue related to my changes in one or more commit messages
• I have added tests that verify my changes
• Unit tests pass locally with my changes
• I have added documentation as necessary
• No Javadoc warnings were introduced with my changes
• No spotbugs warnings were introduced with my changes
• I have interactively tested my changes

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

• Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)

Further comments

Junit 3 tests can be sorted according to alphabet order in GitAPITestCase and compared with GItClientTestCases. It would be an efficient idea to change the tests to Junit 4.

[MarkEWaite]

Thanks very much! I believe the commit is missing from the repository that is being created in the replaced test.

I've also asked a question about the exception in the test that is being transformed. The previous test only asserted the existence of an exception. There are many different issues that may be placed into the single GitException. I'd appreciate very much if you'd be willing to assert more specifically about the contents of the GitException.

[MarkEWaite]

Thanks for reworking the clone and for the additional tests. A few more changes needed

[MarkEWaite]

This looks great! Thanks very much @loghijiaha