Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert added 3 second delay in test #1151

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Revert added 3 second delay in test #1151

merged 1 commit into from
Jun 18, 2024

Conversation

MarkEWaite
Copy link
Contributor

Revert added 3 second delay in test

Prior discussion notes that the sleep does not actually help the test other than to delay its completion.

This reverts commit fb9d2ca.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

What types of changes does your code introduce?

  • Test

@MarkEWaite
Revert "[BEE-47337] added a delay of 3 seconds (jenkinsci#1122)"
59fcbef 
jenkinsci#1122 (comment)
notes that the sleep does not actually help the test other than to delay
its completion.

This reverts commit fb9d2ca.
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Jun 18, 2024
@MarkEWaite MarkEWaite requested a review from a team as a code owner June 18, 2024 20:31
@github-actions github-actions bot added the tests Automated test addition or improvement label Jun 18, 2024
@MarkEWaite MarkEWaite mentioned this pull request Jun 18, 2024
Merged
4 tasks
@MarkEWaite MarkEWaite removed the tests Automated test addition or improvement label Jun 18, 2024
@MarkEWaite MarkEWaite enabled auto-merge (squash) June 18, 2024 20:32
@MarkEWaite MarkEWaite merged commit 37e7280 into jenkinsci:master Jun 18, 2024
14 of 15 checks passed
@MarkEWaite MarkEWaite deleted the remove-3-second-delay-from-submodule-test branch July 9, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Automated test addition or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite