Features/fitnesse plugin fix fitnesse server start

[antoine-aumjaud]

This plugin looks at standard outuput to know if Fitnesse server is started.

Last version of Fitnesse doesn't write on stdout when the server start.
(since unclebob/fitnesse@91e93be - commit date: 13 nov 2013 - impacted version 20140201 & 20140418)

I've replaced this check by verify the target Fitnesse URL (do a HTTP GET on it).

[cloudbees-pull-request-builder]

plugins » fitnesse-plugin #19 SUCCESS
This pull request looks good

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[cloudbees-pull-request-builder]

plugins » fitnesse-plugin #20 SUCCESS
This pull request looks good

[lessonz]

Nit: what happened to the indentation here?

[antoine-aumjaud]

:), I don't know... I will push this soon.

[lessonz]

I apologize my review can't be more substantive as I am currently pressed for time. I hope to be able to do a more in depth review of the pull request in the coming days.

I do have two suggestions for you in general:

1. I can't speak for anyone else, but I feel pull requests are best/easiest when they only deal with the change at hand, in this case the move to HTTP get from reading stdout. So the changing the log facility and reformatting were superfluous to the change at hand and could have been separate pull requests.
2. Building on that, changing parameters named log to instance variables named logger and one line if statements to two line statements when such changes are not in your new code can be viewed as the equivalent of a curly brace war. (Personally I think all compound statements, even one liners, should be enclosed in braces, but that's neither here nor there. I only mention it to point out I'm not a big fan of a lot of how the code is either.)

In any event, thank you very much for your contribution. I hope to be able to merge it soon.

[antoine-aumjaud]

Thanks for advice. Next time, I will remove auto format in my IDE and try to not reformat code which not concerns the pull request.
And yes, I should have split this pull request in 2.

[cloudbees-pull-request-builder]

plugins » fitnesse-plugin #21 SUCCESS
This pull request looks good

[cloudbees-pull-request-builder]

plugins » fitnesse-plugin #22 SUCCESS
This pull request looks good

[cloudbees-pull-request-builder]

plugins » fitnesse-plugin #23 SUCCESS
This pull request looks good