Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show credential ID in DomainWrapper view #120

Conversation

chriskilding
Copy link

Currently the credential ID is shown in the global credentials screen (/credentials), but not in the domain-scoped credentials screen (/credentials/store/system/domain/_/), which makes it a little harder for users to work with domain-scoped credentials.

This PR adds the credential ID to the domain-scoped credentials screen, so that users no longer need to look at the path in their address bar to work out the credential ID they should paste into their Jenkinsfiles.

@chriskilding
Copy link
Author

Note: the proposed design of the domain-scoped credentials screen is not the final one, hence this PR is marked as a Draft to let us discuss it.

@chriskilding
Copy link
Author

This is what the proposed change would render:

image001

@jeffret-b
Copy link
Contributor

Makes sense to me. I don't see any reason the ID isn't shown for domains. I'm not great at UI design, but this proposal looks simple and satisfactory to me.

@chriskilding chriskilding marked this pull request as ready for review July 22, 2019 09:33
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , I think it is really helpful

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvz jvz merged commit 1564c4b into jenkinsci:master Feb 24, 2020
jvz added a commit to jvz/acceptance-test-harness that referenced this pull request Apr 6, 2020
This updates credential lookup for the plugin post-application of
jenkinsci/credentials-plugin#120
@jvz
Copy link
Member

jvz commented Apr 6, 2020

See linked PR for acceptance test updates affected by this change. It seems they were a bit fragile and were checking for the description on the tooltip! I've updated the test to do an additional xpath query for the updated UI.

@chriskilding chriskilding deleted the support/show-credential-id-in-domain-wrapper-view branch April 8, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants