Address review feedback

jenkinsci · Jan 31, 2024 · 0620d25 · 0620d25
1 parent 662b16b
commit 0620d25
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/cloudbees/plugins/credentials/SystemCredentialsProvider.java b/src/main/java/com/cloudbees/plugins/credentials/SystemCredentialsProvider.java
@@ -326,7 +326,7 @@ private synchronized boolean updateCredentials(@NonNull Domain domain, @NonNull
         checkPermission(CredentialsProvider.UPDATE);
         Map<Domain, List<Credentials>> domainCredentialsMap = getDomainCredentialsMap();
         if (domainCredentialsMap.containsKey(domain)) {
-            if (current instanceof IdCredentials && replacement instanceof IdCredentials) {
+            if (current instanceof IdCredentials || replacement instanceof IdCredentials) {
                 if (!current.equals(replacement)) {
                     throw new IllegalArgumentException("Credentials' IDs do not match, will not update.");
                 }

diff --git a/src/main/java/com/cloudbees/plugins/credentials/UserCredentialsProvider.java b/src/main/java/com/cloudbees/plugins/credentials/UserCredentialsProvider.java
@@ -395,7 +395,7 @@ private synchronized boolean updateCredentials(@NonNull Domain domain, @NonNull
             checkPermission(CredentialsProvider.UPDATE);
             Map<Domain, List<Credentials>> domainCredentialsMap = getDomainCredentialsMap();
             if (domainCredentialsMap.containsKey(domain)) {
-                if (current instanceof IdCredentials && replacement instanceof IdCredentials) {
+                if (current instanceof IdCredentials || replacement instanceof IdCredentials) {
                     if (!current.equals(replacement)) {
                         throw new IllegalArgumentException("Credentials' IDs do not match, will not update.");
                     }

diff --git a/src/test/java/com/cloudbees/plugins/credentials/MockFolderCredentialsProvider.java b/src/test/java/com/cloudbees/plugins/credentials/MockFolderCredentialsProvider.java
@@ -333,7 +333,7 @@ private synchronized boolean updateCredentials(@NonNull Domain domain, @NonNull
             checkPermission(CredentialsProvider.UPDATE);
             Map<Domain, List<Credentials>> domainCredentialsMap = getDomainCredentialsMap();
             if (domainCredentialsMap.containsKey(domain)) {
-                if (current instanceof IdCredentials && replacement instanceof IdCredentials) {
+                if (current instanceof IdCredentials || replacement instanceof IdCredentials) {
                     if (!current.equals(replacement)) {
                         throw new IllegalArgumentException("Credentials' IDs do not match, will not update.");
                     }