Remove Jenkins test harness from hpi file #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve a maven warning by not declaring a test dependency when a compile dependency is already declared.
jenkinsci/jenkins#8714 included in Jenkins 2.434 and later will refuse to load a plugin that includes the Jenkins test harness. The Jenkins test harness causes unexpected failures when it is included in a Jenkins plugin. Refer to the following issue reports for examples: * https://issues.jenkins.io/browse/JENKINS-65650 * https://issues.jenkins.io/browse/JENKINS-66060 * https://issues.jenkins.io/browse/JENKINS-72353 The additional benefit of the change is that it makes the plugin hpi file over 90% smaller. Before this change, the plugin hpi file had the following contents: 1680 images/docker.svg 765 META-INF/MANIFEST.MF 84 META-INF/maven/io.jenkins.plugins/container-image-link/pom.properties 5342 META-INF/maven/io.jenkins.plugins/container-image-link/pom.xml 327135 WEB-INF/lib/commons-io-2.11.0.jar 307305 WEB-INF/lib/commons-net-3.8.0.jar 13633 WEB-INF/lib/container-image-link.jar 9277 WEB-INF/lib/crypto-util-1.5.jar 98115 WEB-INF/lib/dec-0.1.2.jar 10579074 WEB-INF/lib/jenkins-test-harness-htmlunit-66.v712ea44bccba.jar 65728 WEB-INF/lib/salvation2-3.0.0.jar 276420 WEB-INF/lib/serializer-2.7.2.jar 220536 WEB-INF/lib/xml-apis-1.4.01.jar 6546 WEB-INF/licenses.xml After this change, the plugin hpi file has the following contents: 1680 images/docker.svg 816 META-INF/MANIFEST.MF 83 META-INF/maven/io.jenkins.plugins/container-image-link/pom.properties 5320 META-INF/maven/io.jenkins.plugins/container-image-link/pom.xml 327135 WEB-INF/lib/commons-io-2.11.0.jar 13661 WEB-INF/lib/container-image-link.jar 9277 WEB-INF/lib/crypto-util-1.5.jar 3444 WEB-INF/licenses.xml
MarkEWaite
changed the title
|
@gabo89 this plugin will not load in Jenkins 2.434 and later until a new release is created with the contents of this pull request A pre-release is available from https://ci.jenkins.io/job/Plugins/job/container-image-link-plugin/job/PR-110/lastSuccessfulBuild/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Jenkins test harness in hpi with Apache commons lang3 plugin
jenkinsci/jenkins#8714 included in Jenkins 2.434 and later will refuse to load a plugin that includes the Jenkins test harness.
The Jenkins test harness causes unexpected failures when it is included in a Jenkins plugin. Refer to the following issue reports for examples:
The additional benefit of the change is that it makes the plugin hpi file over 90% smaller.
Before this change, the plugin hpi file had the following contents:
After this change, the plugin hpi file has the following contents:
Also removes duplicate dependency declarations.
Testing done
Automated tests pass.
Submitter checklist