Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displayName and description to PropertyMigration #471

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

strangelookingnerd
Copy link
Contributor

The UI of the administrative monitor for PropertyMigration seems to be broken since it is missing a display name:

grafik

This PR adds a display name and a descripton for the monitor:

grafik

I'd be happy to change the label / description to something more elaborate, suggestions are highly welcome.

Testing done

Manually verified the UI looks as expected.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner July 24, 2024 08:16
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I had recently noticed this too. Weird that getDisplayName is not simply abstract.

@jglick jglick added the bug label Jul 24, 2024
@jglick jglick merged commit 969d9eb into jenkinsci:master Jul 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants