RateLimitBranchProperty: Fix checking queue for other items tied to the same task

[Vlatombe]

getId is not comparable, but getInQueueSince is.

This also adds a LoggerRule to the test class to make the test output more readable.

cc @jglick

Testing done

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jglick]

Now printing

foo/master with queue id 4 blocked by queue id 3 was first

as expected.

[jglick]

I suspect you need a short pause between

branch-api-plugin/src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java

Lines 250 to 253 in f9e35c4

	QueueTaskFuture<FreeStyleBuild> future = master.scheduleBuild2(0);
	QueueTaskFuture<FreeStyleBuild> future2 = master.scheduleBuild2(0, (Cause) null,
	new ParametersAction(
	Collections.singletonList(new StringParameterValue("FOO", "MANCHU"))));

to ensure that the items have distinct start times, since this is only millisecond resolution; or

branch-api-plugin/src/main/java/jenkins/branch/RateLimitBranchProperty.java

Line 540 in f9e35c4

if (i.getInQueueSince() < item.getInQueueSince()) {

should use <= while checking (&&) that the Items or their ids are !=.

[Vlatombe]

The latter makes more sense to me since in theory this condition can still happen (if jobs are triggered via a script).

#385