Tone down warning about rawWorkspaceDir from WorkspaceLocatorImpl
#258
Conversation
| if (rawWorkspaceDir.startsWith("${ITEM_ROOTDIR}/")) { | ||
| LOGGER.log(Level.WARNING, "JENKINS-2111 path sanitization ineffective when using legacy Workspace Root Directory ‘{0}’; switch to ‘$'{'JENKINS_HOME'}'/workspace/$'{'ITEM_FULL_NAME'}'’ as in JENKINS-8446 / JENKINS-21942", rawWorkspaceDir); | ||
| } else { | ||
| LOGGER.log(Level.FINE, "JENKINS-2111 path sanitization ineffective when using unrecognized Workspace Root Directory ‘{0}’; switch to ‘$'{'JENKINS_HOME'}'/workspace/$'{'ITEM_FULL_NAME'}'’", rawWorkspaceDir); |
There was a problem hiding this comment.
IDK how useful this message was in the first place or whether this branch is a case we would ever expect non-JFR users to run into. Would it make sense to have JFR set a generic (IsJenkinsfileRunner=true) system property or something like that, and then we could check for that in these kinds of cases instead to avoid affecting non-JFR users? Or do we only expect this branch to be hit by JFR users?
There was a problem hiding this comment.
Not sure. I just know that in case neither the old nor new default workspace dir pattern match, you are probably in some special setup and did not really care about the refined behavior of WorkspaceLocatorImpl. Especially on the controller node—none of this applies to agents.
|
Could I get someone to merge & release this please? |
In the case of JFR https://github.com/jenkinsci/jenkinsfile-runner/blob/69c70e5c6ae070151cf2890f96ae60031aae9d23/bootstrap/src/main/java/io/jenkins/jenkinsfile/runner/bootstrap/commands/PipelineRunOptions.java#L16-L24 + https://github.com/jenkinsci/jenkinsfile-runner/blob/69c70e5c6ae070151cf2890f96ae60031aae9d23/bootstrap/src/main/java/io/jenkins/jenkinsfile/runner/bootstrap/commands/RunJenkinsfileCommand.java#L18-L41 this warning
is just noise.