Do not printStackTrace on an exception you are going to rethrow #220
Conversation
| @@ -1509,7 +1509,7 @@ public void complete() throws IllegalStateException, IOException, InterruptedExc | |||
| } catch (InterruptedException | IOException x) { | |||
| throw x; | |||
| } catch (Exception x) { | |||
| x.printStackTrace(listener.error("Failed to create or update a subproject " + projectName)); | |||
| printStackTrace(x, listener.error("Failed to create or update a subproject " + projectName)); | |||
There was a problem hiding this comment.
Separate fix to use the Jenkins cause chaining.
BTW you can just click Re-run on the Jenkins check. |
|
noting user (well test also) based regressions when indexing is interrupted. now there is no sign of what went wrong or where - the details of the |
|
What kind of interesting stack trace were you expecting from an |
|
it does not even need a stack trace, just "it was interrupted" will do (because at the moment all you see is ABORTED and you have no idea why). the stack is useful to know where if you do want more info, and that is available if you turn on FINEST logging, but first you would need to know - and given aborting is usually by a user, (or step if you are in a regular job) both of which are generally accompanied by a log to say why, this leaves the case of some for of InteruptedEx where you no longer have that log anymore and you are like 🤷 Given BitBucket branch source has an explicit test for this I can only assume that some part of the API Can throw this exception under some conditions (yes the test needs to be changed, but all you are left with in the log is aborted with no clue as to why) |
Well, |
Noticed in jenkinsci/mercurial-plugin#149 that the
AbortExceptiongets a stack trace printed (which is wrong—it is a user error) even though https://github.com/jenkinsci/cloudbees-folder-plugin/blob/3afb5acfeeca5a89cf97edc88e8d497b327667c3/src/main/java/com/cloudbees/hudson/plugins/folder/computed/FolderComputation.java#L171-L174 was going to print it politely at the end of the branch indexing log.You should only print a stack trace if you are not rethrowing an exception.