[JENKINS-61956] Adapt test to stricter enforcement of createFreeStyleProject arg

[jglick]

Compatibility with @calvinpark’s jenkinsci/jenkins#4684. Noticed in #199.

[jglick]

BTW I checked workflow-multibranch and saw some failures, but not obviously related. In particular I was worried about https://github.com/jenkinsci/workflow-multibranch-plugin/blob/388dedec6917d2c4ea4d7c583f3ddb465e92db06/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowBranchProjectFactoryTest.java#L56-L70 but this passed against 2.237. That is because ComputedFolders go through a different mechanism to add children, so they are allowed to have children with for example % in the name even though checkGoodName would not tolerate that.

[calvinpark]

In my testing of the workflow-multibranch for jenkinsci/jenkins#4684, the "illegal characters" in checkGoogName were properly encoded therefore were not affected by the change jenkinsci/jenkins#4684 (comment)

For your remark on ComputedFolder, is that a false positive that should also run checkGoodName, or is it passing as it should?

[jglick]

the "illegal characters" in checkGoogName were properly encoded therefore were not affected by the change

I think you are misreading the situation. https://github.com/jenkinsci/jenkins/blob/0eca516e80de6ebd6183b3cca670d8f56c6f5500/core/src/main/java/jenkins/model/Jenkins.java#L4030 indeed rejects %, which for example would be in the Item.name arising from a branch containing a /, but it does not matter because ComputedFolder is using another mechanism to add generated children which bypasses your patch.

[dwnusbaum]

Thanks!