If we are catching PomExecutionException do not claim SUCCESS
#1362
Conversation
| elif grep -q -F -e '<status>COMPILATION_ERROR</status>' pct-report.xml; then | ||
| echo 'PCT failed with compilation error' >&2 | ||
| cat pct-report.xml | ||
| exit 1 |
There was a problem hiding this comment.
| # | ||
| # Previous versions of PCT claimed that there were test failures even when no tests had been | ||
| # run at all. While it is possible that current versions of PCT no longer exhibit this | ||
| # pathology, we err on the side of caution and check anyway. | ||
| # | ||
| echo 'PCT marked failed, checking to see if that is due to a failure to run tests at all' >&2 |
There was a problem hiding this comment.
I thought about deleting this logic entirely, but I failed to convince myself that it was not needed, so better safe than sorry.
| check=false | ||
| levels=$(echo "$t" | tr / '\n' | wc -l) | ||
| short_name=$(echo "$t" | tr / '\n' | grep -v ^target$ | tail -1) | ||
| if [[ $levels -lt 4 ]]; then | ||
| # Single-module project or root module of multi-module | ||
| # project: always check. | ||
| check=true | ||
| elif [[ $PLUGINS =~ $short_name ]]; then | ||
| # Submodule of multi-module project: only check if the | ||
| # directory name of the submodule is a substring of the | ||
| # list of plugins we are testing. | ||
| check=true | ||
| fi | ||
| if $check && [[ -f "${t}/test-classes/InjectedTest.class" ]] && [[ ! -f "${t}/surefire-reports/TEST-InjectedTest.xml" ]] && [[ ! -f "${t}/failsafe-reports/TEST-InjectedTest.xml" ]]; then |
There was a problem hiding this comment.
I really hated this code (which I wrote in a previous PR) because it is quite convoluted and fragile. I was hoping to get rid of it entirely, as it is not needed in many cases where it was previously needed as of newer versions of PCT, but it is still needed in one case, described in the comments above. That case is simple to work around with a simple rm, so I opted to trade one complex and fragile workaround for a simpler (but still fragile) workaround. This I call progress.
| @@ -41,7 +41,7 @@ for LINE in $LINEZ; do | |||
| done | |||
|
|
|||
| # TODO find a way to encode this in some POM so that it can be managed by Dependabot | |||
| version=1178.vbef3c43d0e69 | |||
| version=1180.v0e40e65a81e1 | |||
There was a problem hiding this comment.
Adopting jenkinsci/plugin-compat-tester#348
Fixes #895 by adopting jenkinsci/plugin-compat-tester#348.