Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plugin Compatibility Tester from 0.2.1 to 0.3.0 #118

Merged
merged 4 commits into from
Oct 5, 2019
Merged

Conversation

@oleg-nenashev oleg-nenashev added chore Reduces future maintenance hacktoberfest labels Oct 4, 2019
prep.sh Outdated
@@ -40,7 +40,7 @@ do
done

# TODO find a way to encode this in some POM so that it can be managed by Dependabot
version=0.2.1
version=0.3.0
timestamp=20190926.172941-2 # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/198
pct=$HOME/.m2/repository/org/jenkins-ci/tests/plugins-compat-tester-cli/${version}-SNAPSHOT/plugins-compat-tester-cli-${version}-${timestamp}.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revert the timestamp stuff added in 453f3d3 to pick up jenkinsci/plugin-compat-tester#198 which I waited for this release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removed it. Of a more robust implementation, there might be a follow-up

prep.sh Outdated Show resolved Hide resolved
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
prep.sh Outdated Show resolved Hide resolved
@jglick
Copy link
Member

jglick commented Oct 4, 2019

there might be a follow-up

You could just set up Incrementals. It is already using the parent POM and ought to be in RPU, so should be easy enough using infra.prepareToPublishIncrementals / .maybePublishIncrementals.

@oleg-nenashev
Copy link
Member Author

oleg-nenashev commented Oct 4, 2019 via email

@jglick jglick merged commit 5784bc7 into master Oct 5, 2019
@basil
Copy link
Member

basil commented Oct 5, 2019

Unfortunately, I do not think PCT 0.3.0 was released correctly. I have empirically observed that it does not contain my fix for jenkinsci/plugin-compat-tester#199 as mentioned in the release notes. From git log:

$ git log -5 plugins-compat-tester-aggregator-0.3.0
commit 20d334349a296a68dd152cd3e9b76b7ad99cc558 (tag: plugins-compat-tester-aggregator-0.3.0)
Author: Oleg Nenashev <o.v.nenashev@gmail.com>
Date:   Fri Oct 4 08:38:56 2019

    [maven-release-plugin] prepare release plugins-compat-tester-aggregator-0.3.0

commit ea23cef4255ffab19f63de2d4d5a5e4916adfd6b
Merge: 4ad3bfc ead8247
Author: Oleg Nenashev <o.v.nenashev@gmail.com>
Date:   Thu Oct 3 03:20:24 2019

    Merge branch 'JENKINS-58113-remove-maven-internal' of https://github.com/oleg-nenashev/plugin-compat-tester into JENKINS-58113-remove-maven-internal

commit 4ad3bfc114301e9212c82292a983fababc74892a
Author: Oleg Nenashev <o.v.nenashev@gmail.com>
Date:   Thu Oct 3 03:19:18 2019

    [JENKINS-58113] - Remove more dependencies after GAE removal

commit 0233e061f5e603aa1345663b3b445aaab3f7262d
Merge: 6781cc4 ba980f3
Author: Oleg Nenashev <o.v.nenashev@gmail.com>
Date:   Thu Oct 3 01:33:56 2019

    Merge remote-tracking branch 'jenkinsci/master' into JENKINS-58113-remove-maven-internal

commit ba980f3b03eb44fd4ea8faf9d88ee839b87e461e
Merge: f7d00ce 1d8d9da
Author: Raúl Arabaolaza Barquin <rarabaolaza@cloudbees.com>
Date:   Mon Sep 30 02:33:49 2019

    Merge pull request #192 from basil/testScoped
    
    Plugin compatibility tester is re-adding test-scoped dependencies rather than merely updating them

Looks like PCT was erroneously released from a local branch corresponding to unmerged PR jenkinsci/plugin-compat-tester#194 rather than master.

@basil
Copy link
Member

basil commented Nov 8, 2019

Looks like PCT was erroneously released from a local branch corresponding to unmerged PR jenkinsci/plugin-compat-tester#194 rather than master.

@oleg-nenashev Gentle ping. Would you be willing to re-release PCT from the correct branch?

@MarkEWaite MarkEWaite deleted the pct-0.3.0 branch February 5, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants