Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SCM information #924

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Update SCM information #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
<email>vincent@latombe.net</email>
</developer>
</developers>
<scm>
<connection>scm:git:git://github.com/jenkinsci/aws-java-sdk-plugin.git</connection>
<scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false" child.scm.url.inherit.append.path="false">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules now retain exactly this configuration rather than appending ${project.artifactId}

<connection>scm:git:https://github.com/jenkinsci/aws-java-sdk-plugin.git</connection>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to https to fix
[WARNING] <connection>scm:git:git://github.com/jenkinsci/aws-java-sdk-plugin.git/aws-java-sdk-ec2</connection> is invalid because git:// URLs are deprecated. Replace it with <connection>scm:git:https://github.com/jenkinsci/aws-java-sdk-plugin.git/aws-java-sdk-ec2</connection>. In the future this warning will be changed to an error and will break the build.

<developerConnection>scm:git:git@github.com:jenkinsci/aws-java-sdk-plugin.git</developerConnection>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to also use HTTPS here: jenkinsci/archetypes#267

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this alone, most devs are setup to use SSH access and so this makes manual security releases less painful in the most part (you are probable not going to need that here) - but it makes things at least less controversial for a patch and the maintainers could choose to adopt this if they wanted at their conveinience.

<url>https://github.com/jenkinsci/aws-java-sdk-plugin</url>
<url>https://github.com/jenkinsci/aws-java-sdk-plugin/</url>
<tag>${scmTag}</tag>
</scm>
<modules>
Expand Down