Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(httpd/restart): provide a cronjob for rollout restart #1331

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Sep 12, 2024

following the last brownout from jenkins-infra/helpdesk#2649
we saw few errors from httpd not handling properly the htaccess content.
This new helm allow to enable an automatic rollout restart of the httpd deployment every hour to ensure httpd file content in pod memories.

we decided to provide a cronjob to restart the pods at pre-defined time (every hours for now), this will lower the impact of that bug. (see jenkins-infra/helpdesk#2649 (comment))

we need to keep in mind that we may need to provide a cleanup for both cronjobs and jobs through the .spec.successfulJobsHistoryLimit and .spec.failedJobsHistoryLimit fields for the first and the .spec.ttlSecondsAfterFinished field for the second

charts/httpd/values.yaml Outdated Show resolved Hide resolved
@smerle33
Copy link
Contributor Author

tested locally on a k3d install:

NAMESPACE            NAME                                       SCHEDULE    SUSPEND   ACTIVE   LAST SCHEDULE   AGE
updates-jenkins-io   updates-jenkins-io-httpd-restart-cronjob   0 * * * *   False     0        <none>          2m54s

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First wave of review. We are in the good direction but some chart element should be updated (a bit of naming, but also default values for some CronJob attributes)

charts/httpd/templates/httpdRestart.yaml Outdated Show resolved Hide resolved
charts/httpd/templates/httpdRestart.yaml Outdated Show resolved Hide resolved
charts/httpd/templates/httpdRestart.yaml Outdated Show resolved Hide resolved
charts/httpd/templates/httpdRestart.yaml Outdated Show resolved Hide resolved
charts/httpd/templates/httpdRestart.yaml Outdated Show resolved Hide resolved
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal added enhancement New feature or request httpd and removed mirrorbits labels Sep 17, 2024
@dduportal dduportal merged commit a5d7376 into jenkins-infra:main Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request httpd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants