-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(httpd/restart): provide a cronjob for rollout restart #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
reviewed
Sep 12, 2024
tested locally on a k3d install:
|
smerle33
force-pushed
the
kub/rollout/restart
branch
from
September 16, 2024 12:09
83ee39f
to
a8d7aa9
Compare
dduportal
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First wave of review. We are in the good direction but some chart element should be updated (a bit of naming, but also default values for some CronJob attributes)
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following the last brownout from jenkins-infra/helpdesk#2649
we saw few errors from httpd not handling properly the htaccess content.
This new helm allow to enable an automatic rollout restart of the httpd deployment every hour to ensure httpd file content in pod memories.
we decided to provide a cronjob to restart the pods at pre-defined time (every hours for now), this will lower the impact of that bug. (see jenkins-infra/helpdesk#2649 (comment))
we need to keep in mind that we may need to provide a cleanup for both cronjobs and jobs through the
.spec.successfulJobsHistoryLimit
and.spec.failedJobsHistoryLimit
fields for the first and the.spec.ttlSecondsAfterFinished
field for the second