Upgrade Winston from 2.x to 3.x #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MattyJ007 I'm not sure if anyone at Jembi is actually still looking at this repo. Any chance you could review or get someone else to take a look? |
This was referenced Aug 20, 2021
Pass the initialised logger in as an argument to plugins so that they can log using the same format and options as the rest of the application. This is mainly for the sake of external plugins which get mounted into the plugins folder since they can no longer require Winston directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jembi team 👋
We're supporting an application which still makes use of Hearth at the moment and are doing a few small changes to make it easier to monitor and observe. We thought we'd contribute some of those changes back up stream.
This PR upgrades Winston from v2 to v3 which will then enable us to use the newer JSON log format to do structured logging.
If you're happy to accept PRs that'd be great, otherwise feel free to close this. There may be a few more incoming.