Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Don't require a restart for 75% of plugins #934

Merged
merged 1 commit into from
Mar 28, 2019
Merged

WIP - Don't require a restart for 75% of plugins #934

merged 1 commit into from
Mar 28, 2019

Conversation

Bond-009
Copy link
Member

No description provided.

JustAMan
JustAMan reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but what about 25% remaining?

@joshuaboniface
Copy link
Member

@Bond-009 What happens to the other 25% of cases? Does it inform, crash, etc.? And how do we know?

@LogicalPhallacy
Copy link
Contributor

I'd like to know about the 75% number as well, but otherwise the code looks OK (It probably needs testing with a malfunctioning plugin just to make sure it doesn't cause a hang).

JustAMan
JustAMan approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we put it in and fix if it breaks :)

@joshuaboniface joshuaboniface merged commit 2dbc115 into jellyfin:master Mar 28, 2019
joshuaboniface added a commit to joshuaboniface/jellyfin that referenced this pull request Apr 2, 2019
@joshuaboniface
Search all subdirectories for Plugins
38fcd31 
This was added in jellyfin#801 which broke the previous plugin install
behaviour. Previously plugins could be loaded from subdirectories
but this search was only for the highest level. Change it to search
all subdirectories instead to restore the previous behaviour.

Also modifies the same option from jellyfin#934, though I'm not 100% sure
if this is needed here.
@joshuaboniface joshuaboniface mentioned this pull request Apr 2, 2019
Merged
@Bond-009 Bond-009 deleted the plugin branch July 24, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAMan JustAMan JustAMan approved these changes

@joshuaboniface joshuaboniface joshuaboniface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bond-009 @joshuaboniface @LogicalPhallacy @JustAMan