Fix transcoded audio not playing #9263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bond-009
approved these changes
Feb 5, 2023
|
Nice catch, thanks for the fix |
Shadowghost
approved these changes
Feb 5, 2023
No problem, glad I can help! Just out of interest, have you seen my other pull request for audio normalization? I know you guys are busy and probably more focused on fixing things than adding, but I would love to know what you think and if it is something that would be added, either with my addition or something else. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes transcoded audio not working when requested from client
Changes
Changed null profile to required tcprofile
Issues
Fixes #9251