Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDHomeRun - Fix incorrect starting offset of buffer span in CheckTunerAvailability. #8726

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

swedishborgie
Copy link
Contributor

@swedishborgie swedishborgie commented Nov 11, 2022

CheckTunerAvailability creates a span from a buffer to pass to the validation function. It appears to be incorrectly using the length as the starting index which is causing the tuner initialization to fail. Fixing this resolved the issue I was having with my HDHR3-US.

Please let me if you would like any additional changes or testing done.

Fixes #7154

Copy link
Member

@Bond-009 Bond-009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, looks like I messed that up almost 2years ago

@cvium cvium merged commit c6e4b0b into jellyfin:master Nov 11, 2022
@Bond-009
Copy link
Member

@swedishborgie could you dump the response of your tuner so I can write a regression test for this?

@swedishborgie
Copy link
Contributor Author

Sure thing! I've attached a dump of the response going into the verify for CheckTunerAvailability(). Here's the response from a HDHR3-US:
image
tuner_lockkey.txt

@GodlyOverlord
Copy link

Hi

I've got a HDHR3-DT tuner thats throwing the same livetvconflictexception errors when attempting to loading a livetv stream.
Unit is latest firmware and my jellyfin install is a brand new fresh Docker install on 10.8.8

Any channel i attempt to start, it throws
[2023-01-06 22:57:54.862 +11:00] [INF] [21] Emby.Server.Implementations.LiveTv.LiveTvManager: Opening channel stream from "Emby", external channel Id: "hdhr_26" [2023-01-06 22:57:54.862 +11:00] [INF] [21] Emby.Server.Implementations.LiveTv.EmbyTV.EmbyTV: Streaming Channel "hdhr_26" [2023-01-06 22:57:54.862 +11:00] [INF] [21] Emby.Server.Implementations.LiveTv.TunerHosts.HdHomerun.HdHomerunHost: GetChannelStream: channel id: "hdhr_26". stream id: "native_bc93a813083fd27724af0d73de3f0359_3c030cd34cf84e59e94182fe6c2f1b7b" profile: "native" [2023-01-06 22:57:54.863 +11:00] [INF] [21] Emby.Server.Implementations.LiveTv.TunerHosts.HdHomerun.HdHomerunHost: Opening HDHR UDP Live stream from "192.168.1.213" [2023-01-06 22:57:54.899 +11:00] [ERR] [21] Emby.Server.Implementations.LiveTv.TunerHosts.HdHomerun.HdHomerunHost: Error opening live stream: MediaBrowser.Controller.LiveTv.LiveTvConflictException: Exception of type 'MediaBrowser.Controller.LiveTv.LiveTvConflictException' was thrown.

@cvium
Copy link
Member

cvium commented Jan 6, 2023

But this PR isn't in 10.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: LiveTV playback with HDHomerun HDHR-US fails
4 participants