Fix GetItems IndexOutOfRangeException when IDs do not exist #8189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you retarget this PR to the release-10.8.z branch? That way we can include it in an patch update. |
… not exist via /Users/.../Items. Previously it was possible for the 'index' values in 'positions' to refer beyond 'size'. [ERR] Error processing request. URL "GET" "/Users/.../Items". System.IndexOutOfRangeException: Index was outside the bounds of the array. at MediaBrowser.Controller.Entities.Folder.SortItemsByRequest(InternalItemsQuery query, IReadOnlyList`1 items) at MediaBrowser.Controller.Entities.Folder.GetItems(InternalItemsQuery query) at Jellyfin.Api.Controllers.ItemsController.GetItems
lukefor
force-pushed
the
getitems-outofrange
branch
from
4d56e2b
to
3bd2cc9
Compare
|
Have retargeted it to release-10.8.z now |
|
Am I crazy or could the entire method not be simplified to |
|
@lukefor Have you had a chance to look at my suggestion? |
|
Have made the suggested change. Problematic curl request is working and returning identical results to the previous fix |
crobibero
approved these changes
Aug 18, 2022
cvium
approved these changes
Aug 18, 2022
jellyfin-bot
pushed a commit
that referenced
this pull request
Sep 24, 2022
Fix GetItems IndexOutOfRangeException when IDs do not exist Original-merge: 527ed06 Merged-by: Claus Vium <cvium@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Kakadus
pushed a commit
to Kakadus/jellyfin
that referenced
this pull request
Oct 2, 2022
Fix GetItems IndexOutOfRangeException when IDs do not exist Original-merge: 527ed06 Merged-by: Claus Vium <cvium@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolve a System.IndexOutOfRangeException when requesting IDs that do not exist via /Users/.../Items. Previously it was possible for the 'index' values in 'positions' to refer beyond 'size'. It seems the code previously assumed that all requested items exist
It caused jellyfin-kodi automatic syncs (i.e. the sync that happens automatically while Kodi is running) to fail as per #3531. I could get a consistent repro by making the same request via curl. With this change, Kodi is automatically syncing again, and the curl request returns correct results.
Issues
Fixes #3531