Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch external streams exceptions #7988

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Catch external streams exceptions #7988

merged 2 commits into from
Jun 23, 2022

Conversation

nyanmisaka
Copy link
Member

@nyanmisaka nyanmisaka commented Jun 21, 2022 •
edited
Loading

Changes

  • Catch external streams exceptions (invalid or empty external streams will break the main video stream)

Issues
Closes #7710

@nyanmisaka nyanmisaka added the stable backport Backport into the next stable release label Jun 21, 2022
@nyanmisaka nyanmisaka linked an issue Jun 21, 2022 that may be closed by this pull request
[Issue]: Unable to get media info. #7710
Closed
1 task
@Shadowghost
Copy link
Contributor

Just an FYI: the build error is also fixed by 3478554

@nyanmisaka
Copy link
Member Author

Just an FYI: the build error is also fixed by 3478554

Alright, I remove the same fix from this PR.
Just ignore that debug error.

@cvium
Copy link
Member

cvium commented Jun 21, 2022

With the new constructor signatures I think there may be some tests failing to build

@nyanmisaka
Copy link
Member Author

nyanmisaka commented Jun 21, 2022 •
edited
Loading

With the new constructor signatures I think there may be some tests failing to build

#7984 This will fix the build.

@cvium
Copy link
Member

cvium commented Jun 21, 2022

With the new constructor signatures I think there may be some tests failing to build

#7984 This will fix the build.

image

@nyanmisaka
Copy link
Member Author

image

Tests fixed.

@Bond-009
Copy link
Member

Debug build failed

@Shadowghost
Copy link
Contributor

If this changes were rebased after merging #7984 the debug build would succeed (see discussion above)

@Bond-009 Bond-009 merged commit a71b190 into release-10.8.z Jun 23, 2022
@Bond-009 Bond-009 deleted the external-streams-exceptions branch June 23, 2022 13:45
jellyfin-bot pushed a commit that referenced this pull request Jun 29, 2022
@Bond-009 @joshuaboniface
Merge pull request #7988 from jellyfin/external-streams-exceptions
d771205 
(cherry picked from commit a71b190)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvium cvium cvium approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue]: Unable to get media info.
5 participants
@nyanmisaka @Shadowghost @cvium @Bond-009 @jellyfin-bot