Update username regex to string literal with escaped - #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoVerto
suggested changes
Mar 16, 2019
| // Usernames can contain letters (a-z + whatever else unicode is cool with), numbers (0-9), dashes (-), underscores (_), apostrophes ('), and periods (.) | ||
| return Regex.IsMatch(username, "^[\\w-'._@]*$"); | ||
| return Regex.IsMatch(username, @"^[\w\-'._@]*$"); |
There was a problem hiding this comment.
A lot more readable, good job!
joshuaboniface
changed the title
joshuaboniface
approved these changes
Mar 16, 2019
There was a problem hiding this comment.
LGTM pending my suggestion on @LeoVerto's review.
Re: the title: please capitalize and use imperative mood :)
joshuaboniface
changed the title
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
anthonylavado
approved these changes
Mar 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The username regex was hard to parse because of the double \ and the unescaped -
Even though it worked this minor fix makes it clearer what it is doing