-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IListingsManager Service #10981
Add IListingsManager Service #10981
Conversation
37cb249
to
3bdaf64
Compare
/// <param name="validateLogin">A value indicating whether to validate login.</param> | ||
/// <param name="validateListings">A value indicating whether to validate listings..</param> | ||
/// <returns>Task.</returns> | ||
Task<ListingsProviderInfo> SaveListingProvider(ListingsProviderInfo info, bool validateLogin, bool validateListings); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we append Async to these function names while we're moving them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I don't add the Async suffix unless there's a sync overload, but if we want to establish that as a convention we can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should, makes it easier to see when a Task isn't properly awaited during code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do analyzers/warnings not cover that already? I would expect build to fail if someone didn't await a method like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should, but in the past things have slipped through
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, in that case I have one more queued PR for this sort of refactoring, then I can make a PR that applies that suffix everywhere in LiveTV
Changes
Adds
IListingsManager
service to manage listings providers and map their channels to tuner channels