Remove some unused client capabilities and sync code #10812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
changed the title
|
(OpenAPI diff fails to generate because I touched BaseItemDto) |
nielsvanvelzen
commented
Jan 4, 2024
crobibero
approved these changes
Jan 4, 2024
Bond-009
approved these changes
Jan 4, 2024
Shadowghost
approved these changes
Jan 5, 2024
|
Hi @nielsvanvelzen this breaks logging in using jellyfin-androidtv 0.16.4 for me (but still works fine on the non-tv android client). Looking at the logcat excerpt below I think the unused capabilities also need removing (or allowed to be null) from jellyfin-sdk-kotlin. |
|
I expected this change to break the Android TV app yes. We will start on support for 10.9 once the first beta for it is out (although removing those fields from the request could be done now). |
skysbird
pushed a commit
to skysbird/jellyfin
that referenced
this pull request
Feb 3, 2024
KrzaQ
added a commit
to KrzaQ/jellyfin
that referenced
this pull request
Feb 13, 2024
nielsvanvelzen
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some legacy stuff that clutters the API.
Changes
Issues