Fix overly aggressive view caching #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
force-pushed
the
fix-view-cache
branch
from
69f8aeb
to
4de2a05
Compare
thornbill
added
needs testing
joshuaboniface
approved these changes
Aug 1, 2024
|
It looks like this breaks modals during playback. We probably need to remove navigation type from the effect dependency array to prevent page re-renders when state changes are pushed. |
|
|
Should be fixed now. This can be tested using this preview url: https://ded825b2.jellyfin-web.pages.dev/ |
thornbill
added a commit
that referenced
this pull request
Aug 5, 2024
Fix overly aggressive view caching Original-merge: 4598d66 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: thornbill <thornbill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ViewManagerPagealways using cached version of views when available. This effectively reverts to the pre-10.9 behavior of only using the cached view onPOPevents (navigating back/forward).Depends on #5825
Issues
Fixes #5656