HtmlVideoPlayer fix and cleanup #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
added
bug
ferferga
approved these changes
Jun 18, 2024
The media element may still have some CSS styles related to aspect ratio, so we need to reset the current aspect ratio after destroying the media element.
dmitrylyzo
force-pushed
the
videoplayer-cleanup
branch
from
df8ed71
to
f507bfb
Compare
This comment has been minimized.
This comment has been minimized.
thornbill
approved these changes
Jun 23, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Jun 25, 2024
HtmlVideoPlayer fix and cleanup Original-merge: 18061ce Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The media element may still have some CSS styles related to aspect ratio, so we need to reset the current aspect ratio after destroying the media element.
Issues
N/A