Fix loading hides too early #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thornbill
approved these changes
Jun 8, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Jun 23, 2024
Fix loading hides too early Original-merge: 674b0b1 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some regressions:
#5402 -
loading.hideis called on any Promise result.#5573 -
loading.showis called beforerunInterceptors.Changes
In case of resolved promise, loading is controlled by player and player events (at least that's how it's designed).
Issues
#5674
This doesn't fixes the problem completely, but reverts 🤞 to its original behavior.