Fix video OSD not fully hiding #5653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
added
bug
Sometimes (maybe in some browsers) onHideAnimationComplete is called on btnPause, and the event listener is disconnecting because it was connected with "once: true". As a result, the `hide` class is not added to the OSD element, allowing the user to interact with transparent elements. Don't connect listener with "once: true".
dmitrylyzo
force-pushed
the
fix-videoosd-hide
branch
from
01d7e07
to
cbedc38
Compare
|
thornbill
approved these changes
Jun 4, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Jun 5, 2024
Fix video OSD not fully hiding Original-merge: 74a3bd8 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (maybe in some browsers)
onHideAnimationCompleteis called onbtnPause, and the event listener is disconnecting because it was connected withonce: true.As a result, the
hideclass is not added to the OSD element, allowing the user to interact with transparent elements.Changes
Don't connect listener with
once: true.Issues
Fixes #5647
Fixes #5650
Fixes #5652
Closes #5595
Closes #5651