Fix chapter marker re-rendering #5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
added
bug
|
nielsvanvelzen
approved these changes
May 23, 2024
dmitrylyzo
reviewed
May 23, 2024
| @@ -203,14 +203,14 @@ function setMarker(range, valueMarker, marker, valueProgress) { | |||
| } | |||
|
|
|||
| function updateMarkers(range, currentValue) { | |||
| if (range.getMarkerInfo) { | |||
| if (range.getMarkerInfo && !range.markerInfo) { | |||
There was a problem hiding this comment.
Isn't markerInfo (as well as the slider itself) preserved when start playing the next video, so the markers won't be updated?
There was a problem hiding this comment.
In my testing it was not.
There was a problem hiding this comment.
I only get to the breakpoint once per refresh. So I assume they are preserved (because videoosd doesn't reload for the next item).
There was a problem hiding this comment.
hmm yeah you are right... I'm not sure how it worked when I originally tested... #5601
This was referenced May 24, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
May 25, 2024
Fix chapter marker re-rendering Original-merge: bd03c43 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
markerInfois already populatedmaterial-iconsclassIssues
I can't find one, but I saw the chapter markers flashing being reported somewhere...