add keybinding to control subtitles offset #5193
Conversation
carlo-colombo
force-pushed
the
subtitle-offset-keybinding
branch
2 times, most recently
from
54eb554
to
dd0b496
Compare
|
carlo-colombo
force-pushed
the
subtitle-offset-keybinding
branch
from
56b9c0d
to
6633a70
Compare
carlo-colombo
force-pushed
the
subtitle-offset-keybinding
branch
from
6633a70
to
4f11d4e
Compare
|
I updated the PR, thank you so much for the support. Is there anything else that I can do for the PR, as updating documentation? Thanks |
carlo-colombo
force-pushed
the
subtitle-offset-keybinding
branch
from
4f11d4e
to
ba58851
Compare
carlo-colombo
force-pushed
the
subtitle-offset-keybinding
branch
from
ba58851
to
9a657ce
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
carlo-colombo
force-pushed
the
subtitle-offset-keybinding
branch
2 times, most recently
from
1ccfdf7
to
d116013
Compare
dmitrylyzo
added
feature
|
This should be tested for cases when there're no subtitles and subtitles are off. UPD: |
carlo-colombo
force-pushed
the
subtitle-offset-keybinding
branch
from
d116013
to
4c20c9e
Compare
|
Updated the PR following the suggestion, but I wonder if the conditional chaining is supported in the older browser that has been mentioned earlier in the discussion (WebKit engines (Tizen 2.x, webOS 1/2).) |
We use Babel to transpile code so that it is supported on older platforms. |
carlo-colombo
force-pushed
the
subtitle-offset-keybinding
branch
3 times, most recently
from
da77704
to
f9c249b
Compare
|
carlo-colombo
force-pushed
the
subtitle-offset-keybinding
branch
from
f9c249b
to
0e3f6fa
Compare
|
Hi, is there anything else that need to be addressed before merging the PR? |
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
|
Cloudflare Pages deployment
|
Changes
Bounding
gandhto control subtitles offset in 0.1 steps, bindings are taken from VLC.The subtitle offset overlay is shown while the offset is increased or decreased by pressing the keys. Pressing the keys while the offset is not shown still changes the offset.
Issues