Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sync info from requested fields #5093

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Remove sync info from requested fields #5093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/apps/experimental/components/library/GenresSectionContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ const GenresSectionContainer: FC<GenresSectionContainerProps> = ({
recursive: true,
fields: [
ItemFields.PrimaryImageAspectRatio,
ItemFields.MediaSourceCount,
ItemFields.BasicSyncInfo
ItemFields.MediaSourceCount
],
imageTypeLimit: 1,
enableImageTypes: [ImageType.Primary],
Expand Down
2 changes: 1 addition & 1 deletion src/components/favoriteitems.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function loadSection(elem, userId, topParentId, section, isSingleSection) {
SortOrder: 'Ascending',
Filters: 'IsFavorite',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio',
CollapseBoxSetItems: false,
ExcludeLocationTypes: 'Virtual',
EnableTotalRecordCount: false
Expand Down
2 changes: 1 addition & 1 deletion src/components/homesections/sections/activeRecordings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function getLatestRecordingsFetchFn(
return apiClient.getLiveTvRecordings({
userId: apiClient.getCurrentUserId(),
Limit: enableOverflow ? 12 : 5,
Fields: 'PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio',
EnableTotalRecordCount: false,
IsLibraryItem: activeRecordingsOnly ? null : false,
IsInProgress: activeRecordingsOnly ? true : null
Expand Down
2 changes: 1 addition & 1 deletion src/components/homesections/sections/nextUp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function getNextUpFetchFn(
oldestDateForNextUp.setDate(oldestDateForNextUp.getDate() - userSettings.maxDaysForNextUp());
return apiClient.getNextUpEpisodes({
Limit: enableOverflow ? 24 : 15,
Fields: 'PrimaryImageAspectRatio,DateCreated,BasicSyncInfo,Path,MediaSourceCount',
Fields: 'PrimaryImageAspectRatio,DateCreated,Path,MediaSourceCount',
UserId: apiClient.getCurrentUserId(),
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Banner,Thumb',
Expand Down
2 changes: 1 addition & 1 deletion src/components/homesections/sections/recentlyAdded.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function getFetchLatestItemsFn(

const options = {
Limit: limit,
Fields: 'PrimaryImageAspectRatio,BasicSyncInfo,Path',
Fields: 'PrimaryImageAspectRatio,Path',
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Thumb',
ParentId: parentId
Expand Down
2 changes: 1 addition & 1 deletion src/components/homesections/sections/resume.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function getItemsToResumeFn(
const options = {
Limit: limit,
Recursive: true,
Fields: 'PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio',
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Thumb',
EnableTotalRecordCount: false,
Expand Down
2 changes: 1 addition & 1 deletion src/components/search/LiveTVSearchResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const LiveTVSearchResults: FunctionComponent<LiveTVSearchResultsProps> = ({ serv
ParentId: parentId,
searchTerm: query,
Limit: 24,
Fields: 'PrimaryImageAspectRatio,CanDelete,BasicSyncInfo,MediaSourceCount',
Fields: 'PrimaryImageAspectRatio,CanDelete,MediaSourceCount',
Recursive: true,
EnableTotalRecordCount: false,
ImageTypeLimit: 1,
Expand Down
2 changes: 1 addition & 1 deletion src/components/search/SearchResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const SearchResults: FunctionComponent<SearchResultsProps> = ({ serverId = windo
ParentId: parentId,
searchTerm: query,
Limit: 100,
Fields: 'PrimaryImageAspectRatio,CanDelete,BasicSyncInfo,MediaSourceCount',
Fields: 'PrimaryImageAspectRatio,CanDelete,MediaSourceCount',
Recursive: true,
EnableTotalRecordCount: false,
ImageTypeLimit: 1,
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/favorites.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ function getFetchDataFn(section) {
SortOrder: 'Ascending',
Filters: 'IsFavorite',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio',
CollapseBoxSetItems: false,
ExcludeLocationTypes: 'Virtual',
EnableTotalRecordCount: false
Expand Down
6 changes: 3 additions & 3 deletions src/controllers/itemDetails/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,7 @@ function renderMoreFromSeason(view, item, apiClient) {
apiClient.getEpisodes(item.SeriesId, {
SeasonId: item.SeasonId,
UserId: userId,
Fields: 'ItemCounts,PrimaryImageAspectRatio,BasicSyncInfo,CanDelete,MediaSourceCount'
Fields: 'ItemCounts,PrimaryImageAspectRatio,CanDelete,MediaSourceCount'
}).then(function (result) {
if (result.Items.length < 2) {
section.classList.add('hide');
Expand Down Expand Up @@ -1264,7 +1264,7 @@ function renderTags(page, item) {
}

function renderChildren(page, item) {
let fields = 'ItemCounts,PrimaryImageAspectRatio,BasicSyncInfo,CanDelete,MediaSourceCount';
let fields = 'ItemCounts,PrimaryImageAspectRatio,CanDelete,MediaSourceCount';
const query = {
ParentId: item.Id,
Fields: fields
Expand Down Expand Up @@ -1681,7 +1681,7 @@ function renderMusicVideos(page, item, user) {
SortOrder: 'Ascending',
IncludeItemTypes: 'MusicVideo',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,BasicSyncInfo,CanDelete,MediaSourceCount'
Fields: 'PrimaryImageAspectRatio,CanDelete,MediaSourceCount'
};

if (item.Type == 'MusicAlbum') {
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ function getItems(instance, params, item, sortBy, startIndex, limit) {
if (params.type === 'nextup') {
return apiClient.getNextUpEpisodes(modifyQueryWithFilters(instance, {
Limit: limit,
Fields: 'PrimaryImageAspectRatio,DateCreated,BasicSyncInfo,MediaSourceCount',
Fields: 'PrimaryImageAspectRatio,DateCreated,MediaSourceCount',
UserId: apiClient.getCurrentUserId(),
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Thumb',
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/livetv/livetvrecordings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export default function (view, params, tabContent) {
latestPromise = ApiClient.getLiveTvRecordings({
UserId: Dashboard.getCurrentUserId(),
Limit: 12,
Fields: 'CanDelete,PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'CanDelete,PrimaryImageAspectRatio',
EnableTotalRecordCount: false,
EnableImageTypes: 'Primary,Thumb,Backdrop'
});
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/livetv/livetvschedule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export default function (view, params, tabContent) {
activeRecordingsPromise = ApiClient.getLiveTvRecordings({
UserId: Dashboard.getCurrentUserId(),
IsInProgress: true,
Fields: 'CanDelete,PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'CanDelete,PrimaryImageAspectRatio',
EnableTotalRecordCount: false,
EnableImageTypes: 'Primary,Thumb,Backdrop'
});
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/movies/moviegenres.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default function (view, params, tabContent) {
SortOrder: 'Ascending',
IncludeItemTypes: 'Movie',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,MediaSourceCount,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,MediaSourceCount',
ImageTypeLimit: 1,
EnableImageTypes: enableImageTypes,
Limit: limit,
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/movies/movies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ export default function (view, params, tabContent, options) {
SortOrder: 'Ascending',
IncludeItemTypes: 'Movie',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,MediaSourceCount,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,MediaSourceCount',
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Banner,Thumb',
StartIndex: 0,
Expand Down
6 changes: 3 additions & 3 deletions src/controllers/movies/moviesrecommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function loadLatest(page, userId, parentId) {
const options = {
IncludeItemTypes: 'Movie',
Limit: 18,
Fields: 'PrimaryImageAspectRatio,MediaSourceCount,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,MediaSourceCount',
ParentId: parentId,
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Banner,Thumb',
Expand Down Expand Up @@ -62,7 +62,7 @@ function loadResume(page, userId, parentId) {
Filters: 'IsResumable',
Limit: screenWidth >= 1600 ? 5 : 3,
Recursive: true,
Fields: 'PrimaryImageAspectRatio,MediaSourceCount,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,MediaSourceCount',
CollapseBoxSetItems: false,
ParentId: parentId,
ImageTypeLimit: 1,
Expand Down Expand Up @@ -162,7 +162,7 @@ function loadSuggestions(page, userId) {
userId: userId,
categoryLimit: 6,
ItemLimit: itemLimit,
Fields: 'PrimaryImageAspectRatio,MediaSourceCount,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,MediaSourceCount',
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Banner,Thumb'
});
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/movies/movietrailers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default function (view, params, tabContent) {
SortOrder: 'Ascending',
IncludeItemTypes: 'Trailer',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,SortName,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,SortName',
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Banner,Thumb',
StartIndex: 0
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/music/musicalbums.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default function (view, params, tabContent) {
SortOrder: 'Ascending',
IncludeItemTypes: 'MusicAlbum',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,SortName,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,SortName',
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Banner,Thumb',
StartIndex: 0
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/music/musicartists.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default function (view, params, tabContent, options) {
SortBy: 'SortName',
SortOrder: 'Ascending',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,SortName,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,SortName',
StartIndex: 0,
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Banner,Thumb'
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/music/musicrecommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function loadLatest(page, parentId) {
const options = {
IncludeItemTypes: 'Audio',
Limit: enableScrollX() ? 3 * itemsPerRow() : 2 * itemsPerRow(),
Fields: 'PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio',
ParentId: parentId,
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Banner,Thumb',
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/shows/tvgenres.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default function (view, params, tabContent) {
SortOrder: 'Ascending',
IncludeItemTypes: 'Series',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,MediaSourceCount,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,MediaSourceCount',
ImageTypeLimit: 1,
EnableImageTypes: enableImageTypes,
Limit: limit,
Expand Down
6 changes: 3 additions & 3 deletions src/controllers/shows/tvrecommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ function loadResume(view, userId, parentId) {
Filters: 'IsResumable',
Limit: screenWidth >= 1600 ? 5 : 3,
Recursive: true,
Fields: 'PrimaryImageAspectRatio,MediaSourceCount,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio,MediaSourceCount',
CollapseBoxSetItems: false,
ParentId: parentId,
ImageTypeLimit: 1,
Expand Down Expand Up @@ -141,7 +141,7 @@ function loadLatest(view, userId, parentId) {
userId: userId,
IncludeItemTypes: 'Episode',
Limit: 30,
Fields: 'PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio',
ParentId: parentId,
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Thumb'
Expand Down Expand Up @@ -179,7 +179,7 @@ function loadNextUp(view, userId, parentId) {
const query = {
userId: userId,
Limit: 24,
Fields: 'PrimaryImageAspectRatio,DateCreated,BasicSyncInfo,MediaSourceCount',
Fields: 'PrimaryImageAspectRatio,DateCreated,MediaSourceCount',
ParentId: parentId,
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Thumb',
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/shows/tvshows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default function (view, params, tabContent) {
SortOrder: 'Ascending',
IncludeItemTypes: 'Series',
Recursive: true,
Fields: 'PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'PrimaryImageAspectRatio',
ImageTypeLimit: 1,
EnableImageTypes: 'Primary,Backdrop,Banner,Thumb',
StartIndex: 0
Expand Down
12 changes: 4 additions & 8 deletions src/hooks/useFetchItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ const fetchGetMovieRecommendations = async (
userId: user.Id,
fields: [
ItemFields.PrimaryImageAspectRatio,
ItemFields.MediaSourceCount,
ItemFields.BasicSyncInfo
ItemFields.MediaSourceCount
],
parentId: parentId ?? undefined,
categoryLimit: 6,
Expand Down Expand Up @@ -144,8 +143,7 @@ const fetchGetItemsBySuggestionsType = async (
limit: 25,
fields: [
ItemFields.PrimaryImageAspectRatio,
ItemFields.MediaSourceCount,
ItemFields.BasicSyncInfo
ItemFields.MediaSourceCount
],
parentId: parentId ?? undefined,
imageTypeLimit: 1,
Expand All @@ -172,8 +170,7 @@ const fetchGetItemsBySuggestionsType = async (
parentId: parentId ?? undefined,
fields: [
ItemFields.PrimaryImageAspectRatio,
ItemFields.MediaSourceCount,
ItemFields.BasicSyncInfo
ItemFields.MediaSourceCount
],
imageTypeLimit: 1,
enableImageTypes: [ImageType.Thumb],
Expand All @@ -194,8 +191,7 @@ const fetchGetItemsBySuggestionsType = async (
userId: user.Id,
fields: [
ItemFields.PrimaryImageAspectRatio,
ItemFields.MediaSourceCount,
ItemFields.BasicSyncInfo
ItemFields.MediaSourceCount
],
parentId: parentId ?? undefined,
imageTypeLimit: 1,
Expand Down
2 changes: 1 addition & 1 deletion src/scripts/itemsByName.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ function getQuery(options, item) {
SortOrder: 'Ascending',
IncludeItemTypes: '',
Recursive: true,
Fields: 'AudioInfo,ParentId,PrimaryImageAspectRatio,BasicSyncInfo',
Fields: 'AudioInfo,ParentId,PrimaryImageAspectRatio',
Limit: 100,
StartIndex: 0,
CollapseBoxSetItems: false
Expand Down
2 changes: 1 addition & 1 deletion src/utils/items.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const getItemFieldsEnum = (
const itemFields: ItemFields[] = [];

if (viewType !== LibraryTab.Networks) {
itemFields.push(ItemFields.BasicSyncInfo, ItemFields.MediaSourceCount);
itemFields.push(ItemFields.MediaSourceCount);
}

if (libraryViewSettings.ImageType === ImageType.Primary) {
Expand Down
Loading