-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Jellyfin and Emby to coexist on the same domain #361
Allow Jellyfin and Emby to coexist on the same domain #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works on FF. Though, you are not targeting the right branch. I think you should be targeting master. This file seems to have been renamed to credentialprovider.js
by vitorsemeano in April.
I added a comment in the corresponding apiclient pull request jellyfin-archive/jellyfin-apiclient-javascript#14 (review) |
Targeting of release branch was intentional, as I consider this a bug fix and not a feature. There is one side effect from this patch - users will get logged out on update. As for the name of the variable, this doesn't really matter to me, but I would prefer |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are good with doing a new release, this LGTM
|
5cad44b
to
1c34f62
Compare
I think |
Jellyfin and Emby both overwrite the
servercredentials3
local storage object when saved auth doesn't match. Renaming this key allows both to stay logged in on the same domain.See jellyfin-archive/jellyfin-apiclient-javascript#14 for corresponding apiclient pr