Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Progressive Web App for Android and iOS #304

Merged
merged 3 commits into from
May 9, 2019

Conversation

simoncaron
Copy link
Contributor

@simoncaron simoncaron commented May 5, 2019

Changes

  • Fixed manifest.json to allow standalone app start on iOS and Android
  • Replaced PWA short name (Emby --> Jellyfin)
  • Added files to support launch screens for iOS web app.
  • Added a 512px icon png for Android launch screen.

This is an interesting replacement for an iOS app for Jellyfin. Launchcreens are a bit of a pain to implement since they must support every resolution available. If having all these links is problematic, I guess we could do without them but the launch screen will be white.

Before, the home screen link opened the browser and navigated to the jellyfin server:

out

Now, the home screen link appear as a native app:

ezgif-1-9bc331c46c36

src/index.html Show resolved Hide resolved
Copy link
Member

@anthonylavado anthonylavado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this

Copy link
Member

@dkanada dkanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should go in the next minor release, it's a nice improvement.

@joshuaboniface joshuaboniface changed the base branch from master to release-10.3.z May 7, 2019 19:17
@joshuaboniface joshuaboniface changed the base branch from release-10.3.z to master May 7, 2019 19:18
@joshuaboniface
Copy link
Member

It would need to be rebased off the release branch to make the release, but I'd be OK with that.

@anthonylavado
Copy link
Member

There appear to be no merge conflicts... It's a pretty straightforward change tbh, with files we don't touch often.

@simoncaron
Copy link
Contributor Author

Let me know what you prefer. I could always fix things on my side and submit a new pull request with the release branch as source.

@DrPandemic
Copy link
Contributor

You don't need a new PR. If you would like to keep this PR you can

  1. Rebase your branch on your repo on release-10.3.z
  2. Force push
  3. Change the target branch at the top of this page (you first need to click on edit)

@simoncaron simoncaron changed the base branch from master to release-10.3.z May 8, 2019 01:34
@simoncaron
Copy link
Contributor Author

Now on release-10.3.z

@anthonylavado anthonylavado merged commit f34ec13 into jellyfin:release-10.3.z May 9, 2019
@skug67
Copy link

skug67 commented May 18, 2019

Doesn't seem to pick up when jellyfin is being served at suburl [https://host.domain.com/emby].

@skug67
Copy link

skug67 commented Jun 7, 2019

Dug around a bit and you can get the suburl working by modifying the "start_url" entry in manifest.json from "/web/index.html" to "/emby/web/index.html" Given that the system is currently listening at /emby as well as the root url, is there any reason not to change this entry so that it works for both default and non-default users? (In the long run we'll hopefully get the ability to configure the listening url on the dashboard, at which point we'll need to link up that setting with the start_url entry in manifest.json -- not that I know how that could be accomplished.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants