Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds web options to support better password resets #211

Merged

Conversation

LogicalPhallacy
Copy link
Contributor

This is related to jellyfin/jellyfin#1149 which adds per user password resets
Changes
Added support for selecting which password reset provider to use per user (if more than one is installed)
Added Strings to support the same for Authentication providers that were missing
Changed the password reset pin creation complete dialog to link to the reset page.
Replaced @anthonylavado 's double credit in the contributors doc with myself.

src/controllers/forgotpassword.js Outdated Show resolved Hide resolved
src/scripts/useredit.js Outdated Show resolved Hide resolved
src/scripts/useredit.js Outdated Show resolved Hide resolved
src/strings/en-us.json Outdated Show resolved Hide resolved
src/strings/en-us.json Outdated Show resolved Hide resolved
JustAMan and others added 2 commits March 27, 2019 10:02
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
Copy link
Member

@EraYaN EraYaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the user settings stuff for the provider I'm not too sure about, seems like the Auth provider should be leading, if it's an LDAP user, the password reset provider should also be one that leads the user to the correct LDAP password reset page.

src/strings/en-us.json Outdated Show resolved Hide resolved
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
@EraYaN
Copy link
Member

EraYaN commented Mar 29, 2019

Since the pin string now has dashes can we make the field auto add dashes? (Like some serial number entry systems do)

@LogicalPhallacy
Copy link
Contributor Author

LogicalPhallacy commented Mar 29, 2019

I'm going to merge and do the dash check on the backend

Edit I guess not cannot merge from phone

@joshuaboniface joshuaboniface merged commit 3cc379d into jellyfin:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants