-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds web options to support better password resets #211
Adds web options to support better password resets #211
Conversation
Merge pull request jellyfin#190 from LogicalPhallacy/master
update to current master
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
…lPhallacy/jellyfin-web into passwordresetimprovements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but the user settings stuff for the provider I'm not too sure about, seems like the Auth provider should be leading, if it's an LDAP user, the password reset provider should also be one that leads the user to the correct LDAP password reset page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
Since the pin string now has dashes can we make the field auto add dashes? (Like some serial number entry systems do) |
I'm going to merge and do the dash check on the backend Edit I guess not cannot merge from phone |
This is related to jellyfin/jellyfin#1149 which adds per user password resets
Changes
Added support for selecting which password reset provider to use per user (if more than one is installed)
Added Strings to support the same for Authentication providers that were missing
Changed the password reset pin creation complete dialog to link to the reset page.
Replaced @anthonylavado 's double credit in the contributors doc with myself.