Conversion to webpack - part3 - routes isolation, module resolution, refactoring appStorage

[vitorsemeano]

Here goes the part 3 of the webpack conversion. This PR focus on module resolution for webpack, and it also focus in some relevant topics:

• Routes isolation: moved all controllers to a specific directory, and moved all routes definition from site.js to routes.js
• Refactor appStorage: merged all appStorage implementations into one single module
• Polifys removal: removed a bunch of unnecessary polifys, since the targets for this would be using a recent client

I also tested this PR with android, fixing some issues.

[JustAMan]

No new issues, please address my remaining comments and I feel I'm fine with the PR.

[vitorsemeano]

I addresses all our comments, please check them again.

[JustAMan]

LGTM

[dkanada]

Just want to make sure the skin related code wasn't for custom CSS or branding? I haven't seen any of that in the frontend yet so maybe it was improperly labeled as the skin.

[vitorsemeano]

For what i remember, i discussed that with @thornbill, and he said something like the code was there but it never worked or something similar. That's why i proceeded with removing it.

[JustAMan]

like the code was there but it never worked or something similar

I think that we can re-implement skins later if we want to. Less code to maintain for now is good - we need a clean foundation for building up anyway.

[joshuaboniface]

@vitorsemeano Looks like we have some conflicts, are you able to resolve those?

[vitorsemeano]

I have merged the changes from upstream, but i think we should wait for PR #197 to be merged into upstream before this one.

[joshuaboniface]

Darn @vitorsemeano #197 caused two more conflicts, able to double-check them?

[vitorsemeano]

Can you check if the merge is ok? I didn't tested. I can only test later tonight.

[vitorsemeano]

After some mess in this branch trying to rebase it, i think i successfully managed to rebase it as intented.

[dkanada]

You probably don't need to move apiclient since we should pull it out soon, but everything else looks good.