Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of changes to the server configuration pages #168

Merged
merged 18 commits into from
Mar 12, 2019
Merged

Lots of changes to the server configuration pages #168

merged 18 commits into from
Mar 12, 2019

Conversation

dkanada
Copy link
Member

@dkanada dkanada commented Mar 6, 2019

I have been trying to simplify the layout of the server settings. I will list some of the larger changes below in no particular order. It could use some testing once I move a few more things around.

  1. The plugin catalog was cloned in five different sections including the old sync interface. This was in the form of appservices.js which was a feature specific plugin page, which I removed in favor of the main plugin page.
  2. There was a network share path setting inside the directory browser component which seemed like an odd place for a setting. I moved it to the General section.
  3. The DLNA page had dead code referencing the streaming bitrate limit, which is currently in the playback section.
  4. I was thinking of moving all path related settings into the General tab and linking it from the Paths widget on the dashboard. (left the transcode and ffmpeg paths in the Transcoding section for now, wanted to get feedback before moving those two)

Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions.
One blocker is the change of behaviour in livetvtuner.js near isM3uVariant(...) check.

I would also like to see comparison screenshots of "before" vs "after", as it's hard to picture in mind what those js/css changes would do to the dashboard.

src/components/apphost.js Show resolved Hide resolved
src/dashboard/dashboardgeneral.js Outdated Show resolved Hide resolved
src/dashboard/dashboardgeneral.js Outdated Show resolved Hide resolved
src/dashboard/dashboardgeneral.js Outdated Show resolved Hide resolved
src/dashboard/dashboardgeneral.js Outdated Show resolved Hide resolved
src/dlnasettings.html Show resolved Hide resolved
src/scripts/notificationsettings.js Outdated Show resolved Hide resolved
src/scripts/notificationsettings.js Outdated Show resolved Hide resolved
src/scripts/plugincatalogpage.js Outdated Show resolved Hide resolved
src/scripts/plugincatalogpage.js Outdated Show resolved Hide resolved
@dkanada
Copy link
Member Author

dkanada commented Mar 9, 2019

@dkanada dkanada marked this pull request as ready for review March 9, 2019 03:04
@cvium
Copy link
Member

cvium commented Mar 9, 2019

Network share path is per path and not a global setting...

Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkanada
Copy link
Member Author

dkanada commented Mar 11, 2019

This pull request is now waiting on the plugin to get moved to the organization.

@joshuaboniface joshuaboniface merged commit 96e4296 into jellyfin:master Mar 12, 2019
@dkanada dkanada deleted the settings branch March 14, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants