Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash when hitting play from movie details #1953

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Oct 1, 2024

Not sure the root cause. Using the movie detail screen to play a tv episode maybe?

Comes from roku.com crash log:

args             roAssociativeArray refcnt=2 count:4 
m                roAssociativeArray refcnt=2 count:6 
playstatetask    roSGNode:PlaystateTask refcnt=1 
scenemanager     roSGNode:SceneManager refcnt=1 
group            roSGNode:VideoPlayerView refcnt=1 
configencoding   roAssociativeArray refcnt=1 count:39 
re               <uninitialized> 
filename         <uninitialized> 
userslastrunversion roString refcnt=1 val:"2.1.4" 
dialog           <uninitialized> 
input            roInput refcnt=1 
device           roDeviceInfo refcnt=1 
deeplinkvideo    <uninitialized> 
msg              roSGNodeEvent refcnt=1 
timespan         <uninitialized> 
reportingnode    <uninitialized> 
itemnode         <uninitialized> 
reportingnodetype <uninitialized> 
itemtype         <uninitialized> 
elapsed          <uninitialized> 
currentscene     <uninitialized> 
currentepisode   <uninitialized> 
i                <uninitialized> 
seasonmetadata   <uninitialized> 
moviemetadata    <uninitialized> 
selecteditem     roSGNode:MovieData refcnt=1 
selecteditemtype roString refcnt=1 val:"Movie" 
audio_stream_idx Integer val:0 (&h0) 
showplaybackoptiondialog <uninitialized> 
photoalbumdata   <uninitialized> 
photoplayer      <uninitialized> 
node             <uninitialized> 
ptr              <uninitialized> 
series           <uninitialized> 
albums           <uninitialized> 
selectedindex    <uninitialized> 
screencontent    <uninitialized> 
viewhandled      <uninitialized> 
query            <uninitialized> 
options          <uninitialized> 
results          <uninitialized> 
btn              roSGNode:Button refcnt=1 
buttons          <uninitialized> 
trailerdata      <uninitialized> 
movie            <uninitialized> 
button           <uninitialized> 
panel            <uninitialized> 
trackselected    <uninitialized> 
info             <uninitialized> 
video            <uninitialized> 
retryvideo       <uninitialized> 
event            roAssociativeArray refcnt=1 count:2 
tmpglobaldevice  <uninitialized> 
posttask         <uninitialized> 
inputeventvideo  <uninitialized> 
popupnode        <uninitialized> 
startingpoint    <uninitialized> 
global           Interface:ifGloba$1 Invalid value for left-side of expression. (runtime error &he4) in pkg:/source/Main.brs(545) 
Backtrace: 
#0  Function main(args As Dynamic) As Voi$1 file/line: pkg:/source/Main.brs(546) 
Local Variables:

which points to this line after running build-prod on 2.1.4: (545)

group.itemContent.selectedAudioStreamIndex = audio_stream_idx

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Oct 1, 2024
@cewert cewert requested a review from a team as a code owner October 1, 2024 16:03
@cewert cewert changed the title Prevent crash when using the play button Prevent crash when hitting play from movie details Oct 1, 2024
@cewert cewert merged commit ef2627d into jellyfin:2.1.z Oct 2, 2024
13 checks passed
@cewert cewert deleted the fix-play-button-crash branch October 2, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants