Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on user selection screen #1858

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 24, 2024

Validate server api request data to prevent app crash on user selection view. Comes from roku.com crash log

Crashlog:

myauthtoken      <uninitialized> 
myusername       <uninitialized> 
passwordentry    <uninitialized> 
userdata         <uninitialized> 
currentuser      <uninitialized> 
mytoken          <uninitialized> 
userselected     <uninitialized> 
saveduser        <uninitialized> 
user             <uninitialized> 
item             <uninitialized> 
publicuserids    <uninitialized> 
publicusersnodes <uninitialized> 
numsavedusers    <uninitialized> 
numpubusers      <uninitialized> 
savedusers       roArray refcnt=1 count:1 
publicusers      Invali$1 activeuser       Invali$1 invalidserver    Boolean (2.1 was roBoolean) val:fals$1 startover        Boolean val:fals$1 serverurl        roString (2.1 was String) refcnt=1 val:"XXX" 
m                roAssociativeArray refcnt=3 count:6 
global           Interface:ifGloba$1 Local Variables: 
   file/line: pkg:/source/Main.brs(48) 
#0  Function main(args As Dynamic) As Voi$1 file/line: pkg:/source/ShowScenes.brs(41) 
#1  Function loginflow() As Dynami$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/source/ShowScenes.brs(41)

which points to this line after running build-prod on 2.1.1:

numPubUsers = publicUsers.count()

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 24, 2024
@cewert cewert requested a review from a team as a code owner July 24, 2024 14:30
@cewert cewert merged commit 8a15bf8 into jellyfin:2.1.z Jul 24, 2024
13 checks passed
@cewert cewert deleted the fix-loginflow-crash branch July 24, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants