Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid movie data crash #1843

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 20, 2024

Ensure data is valid before using to prevent app crash. This comes from the roku.com crash log

Crashlog:

source           <uninitialized> 
json             Invali$1 m                roAssociativeArray refcnt=2 count:2 
global           Interface:ifGloba$1 Local Variables: 
   file/line: pkg:/components/data/MovieData.brs(8) 
#0  Function setfields() As Voi$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/data/MovieData.brs(8)

Which points to this line after running build-prod on 2.0.8:

m.top.id = json.id

Changes

  • validate data to prevent crash

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 20, 2024
@cewert cewert requested a review from a team as a code owner July 20, 2024 12:45
@cewert cewert merged commit 4d1ea1a into jellyfin:2.1.z Jul 21, 2024
13 checks passed
@cewert cewert deleted the fix-movie-data-crash branch July 21, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants