Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screenshot make target #1758

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

AlexRFox
Copy link

Changes

make screenshot didn't work when I tried it. Adding this line seems to fix it.

Issues

@AlexRFox AlexRFox requested a review from a team as a code owner March 23, 2024 02:03
@1hitsong
Copy link
Member

Can any of y'all on Linux/Mac try this? On Windows I've never gotten make to do anything.

@AlexRFox
Copy link
Author

This was on Ubuntu, I can check on a Mac in the near future. Though it would be better to have someone else check it out to make sure it's just something about my setups!

Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well using Ubuntu 20 with WSL v2. Thanks for the PR!

Without this PR, make install seems to grab the last screenshot that was take or nothing.

With this PR, make install takes a new screenshot of the current screen.

@cewert cewert added the dev-improvement This improves the dev experience in some way. label Apr 7, 2024
@cewert cewert merged commit ca532ec into jellyfin:master Apr 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-improvement This improves the dev experience in some way.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants