Add logo and season/episode numbers to OSD #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
neilsb
approved these changes
Mar 15, 2024
|
Do we know when a version of the Roku app with these OSD changes will be released? |
I got it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Display Logo
If a logo is available, display it in the top left of the OSD.
For movies, hide the title text if we're showing the logo.
For episodes, move the title text to the right as much as needed to accommodate the logo.
Move the option controls button group down if needed to make space.
Season and Episode Number
For episodes, display season number and episode number under the title text.
Move the option controls button group down if needed to make space.
Screenshots
Feature Request
https://features.jellyfin.org/posts/2553/roku-osd-include-season-and-episode-next-to-title