Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio track selection to video player OSD #1522

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

1hitsong
Copy link
Member

@1hitsong 1hitsong commented Nov 20, 2023

Changes

Adds audio track selection popup to video player's OSD

Demo

Audiotrackselection.mp4

@1hitsong 1hitsong added the new-feature A new feature that currently doesn't exist. label Nov 20, 2023
@1hitsong 1hitsong requested a review from a team as a code owner November 20, 2023 21:00
@jellyfin-bot
Copy link
Contributor

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

@jellyfin-bot jellyfin-bot added the stale This issue/PR has gone stale. label Dec 12, 2023
@cewert cewert removed the stale This issue/PR has gone stale. label Dec 12, 2023
@cewert cewert changed the base branch from unstable to master December 14, 2023 15:06
@jellyfin-bot
Copy link
Contributor

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

@jellyfin-bot jellyfin-bot added the stale This issue/PR has gone stale. label Jan 5, 2024
@1hitsong 1hitsong removed the stale This issue/PR has gone stale. label Jan 6, 2024
@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Jan 6, 2024
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Jan 9, 2024
@jimdogx
Copy link
Contributor

jimdogx commented Jan 27, 2024

Verified:

  1. Can select alternate track.
  2. Can switch back to original track.
  3. If alternate track is selected before playing, Select Audio dialog shows that the alternate is already selected.
  4. Switched back and forth a bunch of times 😄

@1hitsong 1hitsong merged commit 5efbc92 into jellyfin:master Jan 27, 2024
11 checks passed
@1hitsong 1hitsong deleted the selectAudio branch January 27, 2024 17:09
@tjlouie
Copy link

tjlouie commented Jun 18, 2024

Was this new feature added? I'm unable to see the audio track selection in the OSD, tested with multiple .mkv files with multiple audio tracks. There is no icon to the right of the "CC" icon on multiple Roku devices on the 2.0.7 client and Jellyfin server 10.9.6

@jimdogx
Copy link
Contributor

jimdogx commented Jun 19, 2024

This was merged to the Master branch, not the 2.0.z branch. So it would go out with the next major release (2.1.0 or 3.0).

@mikewhitby
Copy link

Thanks @1hitsong this is really useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A new feature that currently doesn't exist.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants