prevent direct play of Dolby TrueHD and DTS #700
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK, no Apple devices support Dolby TrueHD or any DTS audio format. Some do support Dolby Atmos, but only over Dolby Digital Plus (EAC3). This PR removes the code block for A12 and up devices which wrongly assumes that they support Dolby TrueHD and DTS. This should force the Jellyfin server to transcode these kinds of audio tracks to compatible formats. Currently, they are sent to the Swiftfin client as-is, which results in no audio.
This should fix the problems described in #643 and #676. I understand that there is currently a refactor for the Device Profile Builder underway in #519, but that has been going on for 6+ months. This is meant as a hot-fix until that effort is complete.
This code HAS NOT been tested.