Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent direct play of Dolby TrueHD and DTS #700

Closed
wants to merge 1 commit into from

Conversation

schrock
Copy link

@schrock schrock commented Feb 15, 2023

AFAIK, no Apple devices support Dolby TrueHD or any DTS audio format. Some do support Dolby Atmos, but only over Dolby Digital Plus (EAC3). This PR removes the code block for A12 and up devices which wrongly assumes that they support Dolby TrueHD and DTS. This should force the Jellyfin server to transcode these kinds of audio tracks to compatible formats. Currently, they are sent to the Swiftfin client as-is, which results in no audio.

This should fix the problems described in #643 and #676. I understand that there is currently a refactor for the Device Profile Builder underway in #519, but that has been going on for 6+ months. This is meant as a hot-fix until that effort is complete.

This code HAS NOT been tested.

@holow29
Copy link
Contributor

holow29 commented Feb 16, 2023

I actually hope to push something to my PR tomorrow that can be used (and take it out of draft status). Obviously up to the maintainers what to do from there, but I thought I'd let you know! (Finally got some time to work on it/figured out that some of the issues I was running into were server-side.)
As an FYI, VLCKit player (not Native player) supports DTS so you should hopefully be able to get that to work as is - however VLCKit player does not support HDR and will only perform tonemapping, so if you have any HDR content, you would want Native (which won't work yet as you know with DTS...). My PR will properly separate profiles between Native and VLCKit since the support is vastly different.

@LePips
Copy link
Member

LePips commented Feb 17, 2023

Yes, I will close this in favor of the overall device builder overhaul.

@LePips LePips closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants