Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Pre-Alpha Downloading Items #362

Closed
wants to merge 16 commits into from

Conversation

LePips
Copy link
Member

@LePips LePips commented Feb 4, 2022

Developer notes discussion about what this is expected to have: #364

I'm going to close #57 because the base has been implemented and has a roadmap.

Right now, it's way messier than I intended due to evolving ideas. However, I know what needs to change but don't have the time. Will figure that out in Pre-Alpha.

As I typically have Alpha features in the Experimental section, the work for this is locked in much of the foundation of the app so for code maintainability it's not behind a flag. However it should still be treated as Experimental as it is very much just an experiment until Beta.

Other Work

Other work that was a part of this:

  • Refactored Notifications
  • Refactored ImageView for async BlurHash and inits for provided failure views

@LePips LePips marked this pull request as draft February 4, 2022 23:55
@LePips
Copy link
Member Author

LePips commented Mar 19, 2022

Every time that I think about and work on this I keep thinking about how I need to redo it so that I don't create a foundation I need to rewrite later on.

@jmshrv
Copy link

jmshrv commented Jul 25, 2022

As someone who is currently rewriting the foundation that they created, here's what I'm thinking of making for Finamp:

Using some sort of relational database (I'm using Isar for Flutter, there's probably something out there for Apple), have downloaded parents and downloaded children. Parents represent albums (in Swiftfin's case, shows/movies), and children represent individual songs (or episodes). Linking is possible with any type, so a parent could depend on a parent, a parent could depend on children, etc. This would allow a tree of dependencies flexible enough to model relations for stuff like artist -> album -> songs. With this, I can easily check which files to delete when a non-leaf is deleted. For example, when deleting an album, you may need to keep some songs as they're depended on by a playlist.

Hopefully this turns out to work, managing downloads is easily the most challenging part of making a Jellyfin client imo (alongside debugging peoples' weird playback errors due to odd formats).

@dm3ch
Copy link

dm3ch commented Jul 30, 2023

Is there any chance that work on this would be resumed anytime soon?

@LePips LePips deleted the downloading-proof-of-concept branch July 4, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Downloads
3 participants