Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateShopping list example with a better TODO example #39

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

Scags104
Copy link
Contributor

@Scags104 Scags104 commented Dec 2, 2023

UpdateShopping list example with a better TODO example

Will allow adding and updating lists with completed checkmarks while referencing any todo entity.

Still working on how to get it to see a response from the service call todo.get_items, the response contains an array of what is in the list we would need to parse through and either check so we dont create duplicates or if the question is asked, what is on my list?

Copy link
Owner

@jekalmin jekalmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
I have a quick suggestion and look forward to hear your thoughts.

examples/function/shopping_list/README.md Show resolved Hide resolved
Yup that does the trick!

Co-authored-by: jekalmin <jekalmin@hotmail.com>
@Scags104
Copy link
Contributor Author

Scags104 commented Dec 3, 2023

Dont know where my comments went but yeah this seems to work nicely in place of the prompt. Thanks!

Any ideas on how to parse a response so we can expand this to using service todo.get_items as well?

Copy link
Owner

@jekalmin jekalmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas on how to parse a response so we can expand this to using service todo.get_items as well?

I'm using core version 2023.11.1, and it doesn't have todo.get_items service.
Is that a new feature in current release? (I couldn't find it in documentation)

If it supports response_variable, you can set response_variable to be "_function_result" like calendar example.

Comment on lines 4 to 8
## Prompt
### add the following to prompts and fill in your list entity ids
```For lists: Ensure you are differentiating and using one of the following as the list parameter: todo.shopping_list for modifying the "shopping list" and todo.to_do for modification to the "to-do list" ```


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If prompt is not necessary anymore, please remove it.

examples/function/shopping_list/README.md Show resolved Hide resolved
@jekalmin jekalmin added this to the 0.0.9 milestone Dec 4, 2023
Copy link
Contributor Author

@Scags104 Scags104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

included changes and now has ability to read lists given 2023.12.x beta

@jekalmin
Copy link
Owner

jekalmin commented Dec 6, 2023

Thanks for a change. It seems to be working well!
I will apply this in next release version(currently released in 0.0.9-beta1).

@jekalmin jekalmin changed the base branch from main to v0.0.9 December 6, 2023 12:33
@jekalmin jekalmin merged commit 5fa3b2f into jekalmin:v0.0.9 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants